Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ownerreference for policy reports #346

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented Jul 21, 2022

Signed-off-by: Issif issif+github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Set the OwnerReference to the Namespace for PolicyReports

Which issue(s) this PR fixes:

#331

Fixes #

Special notes for your reviewer:

Signed-off-by: Issif <issif+github@gadz.org>
@Issif Issif changed the title set ownerreference for policy reports WIP: set ownerreference for policy reports Jul 21, 2022
@poiana poiana requested review from cpanato and leogr July 21, 2022 15:16
Signed-off-by: Issif <issif+github@gadz.org>
fjogeleit
fjogeleit previously approved these changes Jul 22, 2022
@poiana
Copy link

poiana commented Jul 22, 2022

LGTM label has been added.

Git tree hash: 2c68c4ed34178fa865746a5dcc69fffe7d9c8d4d

Signed-off-by: Issif <issif+github@gadz.org>
@poiana poiana removed the lgtm label Jul 22, 2022
@poiana poiana requested a review from fjogeleit July 22, 2022 08:35
@Issif Issif changed the title WIP: set ownerreference for policy reports set ownerreference for policy reports Jul 22, 2022
Signed-off-by: Issif <issif+github@gadz.org>
Signed-off-by: Issif <issif+github@gadz.org>
@poiana poiana added the lgtm label Jul 22, 2022
@poiana
Copy link

poiana commented Jul 22, 2022

LGTM label has been added.

Git tree hash: 8000cdb43711b32b862cb110779c9076da3f6ae7

@poiana
Copy link

poiana commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6837830 into master Jul 22, 2022
@poiana poiana deleted the owner-ref-policyreport branch July 22, 2022 09:23
Lowaiz added a commit to Lowaiz/charts that referenced this pull request Jul 27, 2022
In prevision of sidekick version bump.
falcosecurity/falcosidekick#346

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Lowaiz added a commit to Lowaiz/charts that referenced this pull request Jul 29, 2022
In prevision of sidekick version bump.
falcosecurity/falcosidekick#346

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
@Issif Issif added this to the 2.27.0 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants